Fix order of lat/lon in wildfire use case#2
Open
mesham wants to merge 1 commit into
Open
Conversation
The latitude and longitude coordinates were read in the
wrong order.
The VESTEC interface asks for "lat/lon" which is internally
stored into upperLeft and lowerRight variables.
These were then wrongly split into individual coords by
lon, lat = upperLeft.split("/")
We corrected this to
lat, lon = upperLeft.split("/")
Also, the min/max coordinates for the hotspot points
were in the wrong order
upperLeft gives latmax and lonmin
lowerRight gives latmin and lonmax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latitude and longitude coordinates were read in the
wrong order.
The VESTEC interface asks for "lat/lon" which is internally
stored into upperLeft and lowerRight variables.
These were then wrongly split into individual coords by
lon, lat = upperLeft.split("/")
We corrected this to
lat, lon = upperLeft.split("/")
Also, the min/max coordinates for the hotspot points
were in the wrong order
upperLeft gives latmax and lonmin
lowerRight gives latmin and lonmax