Conversation
for transparency, see the exact details that is sent automatically to the owner of the instance: - job id - convert from - convert to - ffmpeg stderr - actual video file (if submitted)
...my bad i realize this earlier
don't index static language urls (doesn't do anything) - robots.txt & sitemap.xml
not-nullptr
left a comment
not-nullptr
left a comment
There was a problem hiding this comment.
overall fine , just some localization issues
| </div> | ||
| <p class="text-muted"> | ||
| {@html link( | ||
| {@html sanitize(link( |
There was a problem hiding this comment.
as discussed internally i really hate our current usage of @html, but we agreed that this unfortunately the best way.
messages/en.json
Outdated
| "vertd_generic_no": "Don't submit", | ||
| "vertd_failed_to_keep": "Failed to keep the video on the server: {error}", | ||
| "vertd_details": "View error details", | ||
| "vertd_details_body": "If you press submit, <b>your video will also be attached</b> alongside the error log being sent to us for review. The following information is the log that we automatically receive:", |
There was a problem hiding this comment.
this feels misleading. whenever a job fails we receive the full job logs via a discord webhook regardless of if they choose to submit the video file. to me, this text reads like "we won't even know this failed unless you press submit"
could be worth getting liam to have a look over all added strings?
There was a problem hiding this comment.
I did originally write this string. You could fix the clarity with something more along the lines of
"vertd_details_body": "If you press submit, <b>your video will also be attached</b> alongside the error log which is always reported to us for review. The following information is the log that we automatically receive:",
There was a problem hiding this comment.
replace it with that now
i forgor also fix inconsistencies with link colours
why does github's web conflict resolver not have highlighting
3 participants
Merge with VERT-sh/vertd#28