You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RADMAX was being improperly set in some VEGAS files. This appears to be due to an error where Model3DThetaSquareCut was always being read regardless of the reconstruction set by the user. I've now passed reco_type to the appropriate section and ensured that it matches.
I tested runlist and file type import and tried with improper and proper reco_type and it all appears to be working well.
Example test: v2dl3-vegas -d --point-like -r 2 -f /homes/wang/lundym/debuggingforothers/bryan/20260218/103110.root /raid/reedbuck/lundym/irf_alloff/ea_ITMgeo_24s_CARE162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p005_4nsb.root out
gives: RAD_MAX = 0.07071067811865475 / Direction cut applied [deg]
and the command (note -r 1): v2dl3-vegas -d --point-like -r 1 -f /homes/wang/l undym/debuggingforothers/bryan/20260218/103110.root /raid/reedbuck/lundym/irf_alloff/ea_ITMgeo_24s_CAR E162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p005_4nsb.root out
and returns RAD_MAX = 360.0 / Direction cut applied [deg]
The behavior now forces the user to correctly match the reconstruction to the right IRF. Currently there is no check that does this but it may be nice to include.
Ok lets ignore the copilot its doing a little too much for whats needed here .... maybe @njucarlchen you can download and run a run to see if it works for you and then we can merge. The failing of the CI is intended and it's all due to the correct RADMAX
First, I converted a stage5 file using v2dl3-vegas -d --point-like -r 2 -f data/112774.St5ITMgeo.med.v2_6_1_1.root irfs/ea_ITMgeo_25s_CARE162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p005_4nsb.root . and found RAD_MAX = 0.07071067811865475
Then, I also tried converting the same file using a larger theta square v2dl3-vegas -d --point-like -r 2 -f data/112774.St5ITMgeo.med.v2_6_1_1.root irfs/ea_ITMgeo_25s_CARE162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p0625_4nsb.root . and found RAD_MAX = 0.25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RADMAX was being improperly set in some VEGAS files. This appears to be due to an error where Model3DThetaSquareCut was always being read regardless of the reconstruction set by the user. I've now passed reco_type to the appropriate section and ensured that it matches.
I tested runlist and file type import and tried with improper and proper reco_type and it all appears to be working well.
Example test:
v2dl3-vegas -d --point-like -r 2 -f /homes/wang/lundym/debuggingforothers/bryan/20260218/103110.root /raid/reedbuck/lundym/irf_alloff/ea_ITMgeo_24s_CARE162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p005_4nsb.root outgives:
RAD_MAX = 0.07071067811865475 / Direction cut applied [deg]and the command (note -r 1):
v2dl3-vegas -d --point-like -r 1 -f /homes/wang/l undym/debuggingforothers/bryan/20260218/103110.root /raid/reedbuck/lundym/irf_alloff/ea_ITMgeo_24s_CAR E162d12_v259rc0v2p1GT_alloff_Z0-60_s700_W1p1_L1p3_MH7_ThSq0p005_4nsb.root outand returns
RAD_MAX = 360.0 / Direction cut applied [deg]The behavior now forces the user to correctly match the reconstruction to the right IRF. Currently there is no check that does this but it may be nice to include.