fix: update VirtualClusterManager → VirtualClusterRegistry in proposal 083 - #3
Closed
SamBarker wants to merge 1 commit into
Closed
fix: update VirtualClusterManager → VirtualClusterRegistry in proposal 083#3SamBarker wants to merge 1 commit into
SamBarker wants to merge 1 commit into
Conversation
…proposal 083 VirtualClusterManager was renamed to VirtualClusterRegistry in the main codebase. Update all references in the proposal accordingly, and fix the orchestration pipeline diagram which incorrectly described VirtualClusterRegistry as a per-VC construct (it is one registry for all clusters). Also clarifies the rejected alternative entry, which was tangled by the rename: the rejected thing was the separate VirtualClusterManager orchestrator shape, not VirtualClusterRegistry itself. Signed-off-by: Sam Barker <sam.barker@example.com> Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VirtualClusterManagerwas renamed toVirtualClusterRegistryin the main codebase yesterday. This PR updates all references in proposal 083 accordingly.Changes:
VirtualClusterManagerwithVirtualClusterRegistrythroughout the proposal proseVirtualClusterRegistryas a per-VC construct — it is one registry for all clustersVirtualClusterManager), notVirtualClusterRegistryitself