Add delegated connection subjects - #1948
Closed
mukul-anand-bhatt wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security model
The delegation credential is separate from user and admin API keys. A matched delegation credential must include a valid account ID and current organization role or authentication fails closed. Existing authentication behavior is unchanged when delegation is not configured.
connectedByis attribution only. Workspace ownership remains shared, and changing a connection to personal ownership still requires an explicit authorized operation.Testing
bun run format:checkbun run lintbun run typecheckTURBO_TEST_CONCURRENCY=4 bun run testbun run --filter @executor-js/sdk testbun run --filter @executor-js/host-selfhost build