fix(toolkits): allow personal connections in toolkits on desktop app (#1925) - #1940
Open
Adityakk9031 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1925 by ensuring toolkits on single-player / desktop hosts allow personal connections to be displayed, added, and managed without multi-tenant workspace isolation restrictions.
Root Cause
owner: "org") and Personal (owner: "user"). To prevent exposing one user's personal credentials to the rest of the organization,orgtoolkits intentionally hide and block personal connections (owner: "user").ToolkitGriddefaulted newly created toolkits toowner: "org", andtoolCanAppearInToolkit/hiddenPersonalConnectionCounttreated desktop toolkits as shared workspace toolkits. When connections were created via CLI or MCP withowner: "user", the UI hid them behind the confusing banner "You have X personal connections that are not shown because this is a shared toolkit" and prevented them from being added to the toolkit.Solution
ToolkitGridon single-player hosts (!ownerDisplay.showOwnerLabels) to create toolkits withowner: "user"so they natively support both personal and local connections.toolCanAppearInToolkitandhiddenPersonalConnectionCountto acceptshowOwnerLabelsand allow all tools when running on single-player / desktop hosts where owner labels are disabled.toolCanAppearInToolkitacross single-player and multiplayer hosts.server.test.tsverifying personal toolkits allow connecting and resolving personal dynamic connection tools.Verification
bun run --cwd packages/plugins/toolkits test(8 passed)bun run --cwd packages/plugins/toolkits typecheck(0 errors)bun run lint(0 errors, 0 warnings)