Skip to content

fix(toolkits): allow personal connections in toolkits on desktop app (#1925) - #1940

Open
Adityakk9031 wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
Adityakk9031:fix/desktop-toolkits-personal-connection
Open

fix(toolkits): allow personal connections in toolkits on desktop app (#1925)#1940
Adityakk9031 wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
Adityakk9031:fix/desktop-toolkits-personal-connection

Conversation

@Adityakk9031

Copy link
Copy Markdown
Contributor

Summary

Resolves #1925 by ensuring toolkits on single-player / desktop hosts allow personal connections to be displayed, added, and managed without multi-tenant workspace isolation restrictions.

Root Cause

  1. In cloud / multiplayer hosts, toolkits distinguish between Workspace (owner: "org") and Personal (owner: "user"). To prevent exposing one user's personal credentials to the rest of the organization, org toolkits intentionally hide and block personal connections (owner: "user").
  2. On desktop / single-player hosts, there is no multi-user workspace partition. However, ToolkitGrid defaulted newly created toolkits to owner: "org", and toolCanAppearInToolkit / hiddenPersonalConnectionCount treated desktop toolkits as shared workspace toolkits. When connections were created via CLI or MCP with owner: "user", the UI hid them behind the confusing banner "You have X personal connections that are not shown because this is a shared toolkit" and prevented them from being added to the toolkit.

Solution

  • Updated ToolkitGrid on single-player hosts (!ownerDisplay.showOwnerLabels) to create toolkits with owner: "user" so they natively support both personal and local connections.
  • Updated toolCanAppearInToolkit and hiddenPersonalConnectionCount to accept showOwnerLabels and allow all tools when running on single-player / desktop hosts where owner labels are disabled.
  • Added unit tests for toolCanAppearInToolkit across single-player and multiplayer hosts.
  • Added test in server.test.ts verifying personal toolkits allow connecting and resolving personal dynamic connection tools.

Verification

  • bun run --cwd packages/plugins/toolkits test (8 passed)
  • bun run --cwd packages/plugins/toolkits typecheck (0 errors)
  • bun run lint (0 errors, 0 warnings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] can't add a connection to toolkits in desktop app

1 participant