Skip to content

test(execution): fix flaky tool-invoker test #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
The-AarushiSingh wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −31
Open

test(execution): fix flaky tool-invoker test #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tool-invoker-test-timeout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@executor-js/execution": patch
---

Give the sandbox describe/invoke contract test a 10s timeout so it does not flake on slow CI.
65 changes: 34 additions & 31 deletions packages/core/execution/src/tool-invoker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,39 +905,42 @@ describe("tool discovery", () => {
}),
);

it.effect("describes a return type that accepts the sandbox invocation result", () =>
Effect.gen(function* () {
const executor = yield* makeSearchExecutor();
const engine = createExecutionEngine({ executor, codeExecutor });
it.effect(
"describes a return type that accepts the sandbox invocation result",
() =>
Effect.gen(function* () {
const executor = yield* makeSearchExecutor();
const engine = createExecutionEngine({ executor, codeExecutor });

const execution = yield* engine.execute(
[
'const details = await tools.describe.tool({ path: "github.org.main.getRepositoryDetails" });',
"const result = await tools.github.org.main.getRepositoryDetails({ owner: 'executor', repo: 'executor' });",
"return {",
" outputTypeScript: details.outputTypeScript,",
" typeScriptDefinitions: details.typeScriptDefinitions,",
" result,",
"};",
].join("\n"),
{ onElicitation: acceptAll },
);
const execution = yield* engine.execute(
[
'const details = await tools.describe.tool({ path: "github.org.main.getRepositoryDetails" });',
"const result = await tools.github.org.main.getRepositoryDetails({ owner: 'executor', repo: 'executor' });",
"return {",
" outputTypeScript: details.outputTypeScript,",
" typeScriptDefinitions: details.typeScriptDefinitions,",
" result,",
"};",
].join("\n"),
{ onElicitation: acceptAll },
);

expect(execution.error).toBeUndefined();
const observed = execution.result as DescribedToolContract & { readonly result: unknown };
const diagnostics = typeCheckDescribedInvocation(
observed,
observed.result,
[
"function readDefaultBranch(result: ToolOutput): string {",
" if (!result.ok) return result.error.message;",
" return result.data.defaultBranch;",
"}",
"readDefaultBranch(invokedResult);",
].join("\n"),
);
expect(diagnostics).toEqual([]);
}),
expect(execution.error).toBeUndefined();
const observed = execution.result as DescribedToolContract & { readonly result: unknown };
const diagnostics = typeCheckDescribedInvocation(
observed,
observed.result,
[
"function readDefaultBranch(result: ToolOutput): string {",
" if (!result.ok) return result.error.message;",
" return result.data.defaultBranch;",
"}",
"readDefaultBranch(invokedResult);",
].join("\n"),
);
expect(diagnostics).toEqual([]);
}),
{ timeout: 10000 },
);

it.effect(
Expand Down
Loading