fix(openapi): preserve vendor +json Content-Type on object bodies - #1937
Open
The-AarushiSingh wants to merge 2 commits into
Open
fix(openapi): preserve vendor +json Content-Type on object bodies#1937The-AarushiSingh wants to merge 2 commits into
The-AarushiSingh wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1930
Why
applyRequestBodyinpackages/plugins/openapi/src/sdk/invoke.tstreats any+jsontype as JSON (isJsonContentType).bodyText(..., contentType)and kept the declared type (application/vnd.api+json).HttpClientRequest.bodyJsonUnsafe(...), which always setsContent-Type: application/json.JSON:API and other vendor
+jsonservers then return 415. Callers cannot pass aContent-Typeheader on the tool call.Change
Object JSON bodies now
JSON.stringifyand go throughbodyTextwith the declared media type, same as strings.Added a test in
non-json-body.test.ts: object body +application/vnd.api+jsonasserts that exact Content-Type on the wire.Out of scope
Editable integration headers on
updateSpec/ configure. That is a separate feature. This PR only fixes the object-body header.