Skip to content

docs(sdk): invoke tools by address, not id - #1916

Open
The-AarushiSingh wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
The-AarushiSingh:docs/tools-invoke-address
Open

docs(sdk): invoke tools by address, not id#1916
The-AarushiSingh wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
The-AarushiSingh:docs/tools-invoke-address

Conversation

@The-AarushiSingh

Copy link
Copy Markdown
Contributor

Why

Tool in packages/core/sdk/src/tool.ts has address (ToolAddress) and no id.
The SDK README called executor.tools.invoke(target.id, ...).

Change

packages/core/sdk/README.md: both invoke examples now use target.address.

Plugin README address strings were already correct. Docs only.

@devin-ai-integration

Copy link
Copy Markdown

Verdict: mergeable. Docs-only, open ~1 day, applies cleanly on current main.

Verified the claim: Tool in packages/core/sdk/src/tool.ts exposes address: ToolAddress and has no id, so the old executor.tools.invoke(target.id, …) examples in packages/core/sdk/README.md would fail to typecheck for anyone copying them. The plugin READMEs already pass address strings, so this brings the SDK README in line.

Ran on the PR branch: bun run format:check — clean. No code changes, so lint/typecheck/tests are unaffected (CI is green). No changeset needed for a README-only change. Nothing pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant