Skip to content

Stop rendering tool-sync failures as connection health - #1914

Draft
RhysSullivan wants to merge 4 commits into
mainfrom
sync-verdict-display
Draft

Stop rendering tool-sync failures as connection health#1914
RhysSullivan wants to merge 4 commits into
mainfrom
sync-verdict-display

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

A failed tool-catalog sync stamps a degraded "Tool sync failing" verdict into connection.last_health. The console rendered that stamp as the connection's health, so one bad sync sweep (a rate-limited upstream, a token race, a slow server) painted whole integration rows DEGRADED for credentials that were fine — an entire list of amber badges that healed seconds later once the page's own syncs and probes ran. The agent-facing list already treats sync stamps as not-refutable-by-probe; the console did the opposite.

  • presentableHealth in the shared health hooks returns null for tool-sync stamps, so neither the integrations-list worst-of summary nor the account rows present them as connection health. Genuine probe verdicts are untouched.
  • Sync-stamped connections still auto-probe on mount (the probe is what discovers the credential's real state — a never-probed connection whose first sync failed must still surface Expired; covered by the health-checks-ui list scenario).
  • The account row shows the sync failure as its own muted note instead of an unhealthy row.
  • isToolSyncHealth is now exported from the SDK's shared surface.

Verified with the health-checks-ui and connection-health-verdict e2e scenarios (cloud target, 12/12) plus the react package suite.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 526a0e9 Commit Preview URL

Branch Preview URL
Sep 01 2026, 06:13 AM

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Console https://executor-preview-pr-1914.executor-e2e.workers.dev
MCP https://executor-preview-pr-1914.executor-e2e.workers.dev/mcp
Deployed commit 526a0e9

Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 526a0e9 Sep 01 2026, 06:14 AM

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1914

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1914

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1914

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1914

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1914

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1914

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1914

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1914

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1914

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1914

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1914

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1914

executor

npm i https://pkg.pr.new/executor@1914

commit: 526a0e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant