fix(e2e): honor the 503 restart envelope in the cap-eviction helper - #1895
fix(e2e): honor the 503 restart envelope in the cap-eviction helper#1895ra-co88 wants to merge 1 commit into
Conversation
3a0b881 to
d4da0e5
Compare
|
Verdict: needs a decision — superseded on main, close or trim to the retry backstop. Open 3 days (since 2026-08-30). Conflicts with main in What's left is the Options:
Not run: lint/typecheck/e2e — the branch doesn't apply to current main and the change is e2e-only test code with no runtime effect, so nothing to verify until it's rebased. Nothing pushed. |
d4da0e5 to
7893ac9
Compare
|
Took option 2 — thanks for catching that #1907 superseded the concurrency half. Rebased onto current main, dropped the concurrency hunk (and the comment rewrite), and kept only the Understood on the evidence point — with sequential admission the envelope is a defensive backstop, not a demonstrated fix. Keeping it because the retry mirrors what a real streamable-http client does with that exact response, so the test's failure mode stays aligned with client behavior if the envelope ever recurs. |
Per review: the concurrency half is superseded by UsefulSoftwareCo#1907 (already on main, stricter). Rebased onto current main and kept only the retry loop on the documented 503 restart envelope.
7893ac9 to
3194bbd
Compare
What
Adds a retry backstop to
openSessionincloud/mcp-session-cap-eviction.test.ts: when the server answersinitializewith the documented restart envelope (503, JSON-RPC -32001,"MCP session is restarting, please retry"— the contractagent-handleremits for a platform DO reset), the helper retries the same request after a short delay instead of failing the scenario on a retryable platform blip.Context
The original root-cause half of this PR (opening concurrency) was superseded by #1907, which landed sequential admission and has the shard green on main. What remains here is only the retry: the exact behavior a real streamable-http client follows for that response, kept so the test's failure mode stays aligned with client behavior if the envelope ever recurs.
Verification
cloud/mcp-session-cap-evictionpasses locally on this branch (rebased onto current main).oxlintandtsc --noEmitclean on the touched package.