test: enforce strict replay sandboxing in e2e fixtures#79
Draft
sohankshirsagar wants to merge 1 commit intomainfrom
Draft
test: enforce strict replay sandboxing in e2e fixtures#79sohankshirsagar wants to merge 1 commit intomainfrom
sohankshirsagar wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| import greeter_pb2 as greeter__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.76.0' | ||
| GRPC_GENERATED_VERSION = '1.78.0' |
There was a problem hiding this comment.
Generated gRPC stub version bump without requirements update
Medium Severity
The regenerated greeter_pb2_grpc.py bumps GRPC_GENERATED_VERSION from '1.76.0' to '1.78.0', but requirements.txt still allows grpcio>=1.60.0. The generated runtime check (first_version_is_lower) raises a RuntimeError at import if the installed grpcio is below 1.78.0. This change is unrelated to the PR's strict-sandbox goal and looks accidentally committed alongside the config changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Enable strict replay sandboxing across the Python e2e and stack-test fixtures so local/CI replay runs exercise the sandboxed path instead of silently falling back. This also updates sandbox-sensitive HTTP fixtures to install SOCKS support, since strict replay routes outbound HTTP through a SOCKS proxy.
Changes
replay.sandbox.mode: strictin all checked-in e2e and stack-test.tusk/config.yamlfixturesappservice in the testdocker-compose.ymlfiles:cap_add: [SYS_ADMIN]security_opt: [seccomp=unconfined, apparmor=unconfined]bubblewrapandsocatin the sharedpython-e2e-baseimage used by the test containershttpxandfastapie2e test requirements to usehttpx[socks]and document why that extra is needed under strict replay sandboxingNotes
httpx-based fixtures needed SOCKS support because replay now intercepts outbound HTTP through a SOCKS proxy