test: enforce strict replay sandboxing in e2e fixtures#141
Merged
sohankshirsagar merged 2 commits intomainfrom Mar 17, 2026
Merged
test: enforce strict replay sandboxing in e2e fixtures#141sohankshirsagar merged 2 commits intomainfrom
sohankshirsagar merged 2 commits intomainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jy-tan
approved these changes
Mar 16, 2026
sohil-kshirsagar
approved these changes
Mar 17, 2026
Contributor
sohil-kshirsagar
left a comment
sohil-kshirsagar
left a comment
There was a problem hiding this comment.
nice! worth updating the e2e testing docs explaining this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require strict replay sandboxing across the Docker-based e2e fixtures and update the test containers so the sandbox can actually start during replay. This also fixes a few compose files where the initial bulk edit misplaced
build.args.Changes
replay.sandbox.mode: strictin all e2e.tusk/config.yamlfiles so replay fails instead of silently falling back to unsandboxed execution.socatandbubblewrapin all Docker-based e2eDockerfiles, since those binaries are required for Linux replay sandboxing.cap_add: [SYS_ADMIN]plussecurity_optoverrides (seccomp=unconfined,apparmor=unconfined) to each e2edocker-compose.ymlappservice.bubblewrapfrom creating the namespaces it needs, which caused strict sandbox startup to fail withOperation not permitted.