S12M timecode support #530
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I guess we do not have a recent enough version of ffmpeg to build it ? |
Author
|
Yes, I guess I would need to add some sort of guard for ffmpeg version? |
Collaborator
|
Yes it would be lovely. |
Collaborator
|
Just add a check for the needed ffmpeg symbols in configure, so you don't need to depend on a specific release. |
nto
reviewed
Dec 17, 2018
| if (side_data) { | ||
| uref_pic_set_s12m(uref, side_data->data, side_data->size); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
What about using the AV_FRAME_DATA_S12M_TIMECODE macro to check for availability :
#ifdef AV_FRAME_DATA_S12M_TIMECODE
side_data = av_frame_get_side_data(frame, AV_FRAME_DATA_S12M_TIMECODE);
if (side_data) {
uref_pic_set_s12m(uref, side_data->data, side_data->size);
}
#endif
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source from lavc, Source/Sink for Blackmagic