Split the omp model into omp-for and omp-target models to avoid making extra copies of buffers - #43
Open
nicolas-bouton wants to merge 3 commits into
Open
Conversation
Remove occurences of `#pragma omp parallel for`. And doesn't change the behavior of the cmake, same variables need to be passed to enable offloading. * CMakeLists.txt, src/main.cpp, src/omp-target/fasten.hpp, src/omp-target/model.cmake: Here. Signed-off-by: Nicolas Bouton <nicolas.bouton@sipearl.com>
Provide a revised version of the `#pragma omp parallel for` implementation that avoids making extra copies of buffers (like the std-ranges model), reducing memory overhead and improving performance. * CMakeLists.txt, src/main.cpp, src/omp-for/fasten.hpp, src/omp-for/model.cmake: Here. Signed-off-by: Nicolas Bouton <nicolas.bouton@sipearl.com>
* src/kokkos/model.cmake: Here. Signed-off-by: Nicolas Bouton <nicolas.bouton@sipearl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR turns the omp model into 2 models, omp-for and omp-target, avoids making extra copies of buffers for the omp-for model based on the std-range model, whereas the omp-target model is still making extra copies of buffers for the device.
The code from the omp model was used as the code for the omp-target model, since the kernel for this model was not modified, so it is clear in the git diff that the code for this model is not touched.
The Kokkos cmake file was also modified to let the user use an already compiled Kokkos library.