docs: updating textbook citations, automated citations produced inaccuracies#143
Merged
Conversation
…uracies cross-checked the Pozar references against the actual 4th edition. two real errors plus one imprecise label: - sikit/si/DiffSynth.cpp cited Pozar §7.2 for the even/odd recombination formulas. §7.2 is T-junction power dividers; the correct section is §7.6 Coupled Line Theory which defines Z_0e / Z_0o and the decomposition this code implements. - sikit/si/SParam.h cited Pozar §7.2 for the PNPN port-ordering convention. Not in Pozar; thats VNA-vendor convention (Keysight/Anritsu app notes). - SParam.h and Topology.h cited Pozar Ch 4 for T-parameter cascade. Pozar §4.4 covers ABCD-matrix cascade (the conceptual idea is the same) but never uses the term T-parameter and does not give the specific S->T conversion the code uses. The right cite for that is Frickey 1994 (IEEE Trans MTT 42(2), pp 205-211). Updated to point at both.
UnsignedChad
enabled auto-merge (squash)
May 29, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-checked the Pozar references in sikit_si against the actual 4th edition. Found three issues:
sikit/si/DiffSynth.cpp cited Pozar §7.2 for the even/odd recombination formulas. §7.2 is The T-Junction Power Divider. The correct section is §7.6 Coupled Line Theory, which defines Z_0e / Z_0o and gives the even/odd decomposition the code implements.
sikit/si/SParam.h cited Pozar §7.2 for the PNPN port-ordering convention. Not in Pozar at all; thats VNA-vendor convention from Keysight / Anritsu app notes.
SParam.h and Topology.h cited Pozar Ch 4 for T-parameter cascade. Pozar §4.4 does cover cascade-by-matrix-multiply (under the name ABCD) but never uses the term T-parameter and does not give the specific S->T conversion this code implements. The canonical reference for that transformation is Frickey 1994, IEEE Trans MTT vol 42 no 2, pp 205-211. Updated both files to point at §4.4 for the cascade idea and Frickey for the conversion.
715 tests pass.
(General reminder: automated citations from the original code generation produced these inaccuracies; worth spot-checking the Ott and Paul cites against physical copies too when convenient.)