hermes-agent [ Crypto ] Fix tx.origin phishing vulnerability in GovernanceToken delegation#5895
Closed
KK88100 wants to merge 1 commit into
Closed
Conversation
…n auth - Replace all tx.origin checks with msg.sender in delegateVote and revokeDelegate - Add Ownable for snapshot() admin function instead of tx.origin check - Add require(msg.sender != address(0)) and require(to != address(0)) guards - Add phishing test verifying malicious contract cannot delegate others' votes - Add Foundry tests covering all acceptance criteria Closes UnsafeLabs#912
Author
|
Payment address for bounty (USDT TRC20): |
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #912
Summary
Replaced all
tx.originauthorization checks withmsg.senderindelegateVoteandrevokeDelegate. Replacedtx.origin == admininsnapshot()withonlyOwnermodifier from OpenZeppelin Ownable. Added zero-address guards and a phishing test that verifies a malicious contract cannot delegate votes on behalf of users who interact with it.Acceptance Criteria
tx.originremains in the contractmsg.senderonlyOwnermodifier protects admin functions (snapshot)Tests
Tests added in solidity/test/GovernanceToken.t.sol using Foundry:
Payment address (USDT TRC20):
TXjaadYhD579e3bCWKnRFKjRq9RZQL7WNj