hermes-agent [ Crypto ] Fix cross-chain replay attack in CrossChainBridge signature verification#5893
Closed
KK88100 wants to merge 1 commit into
Closed
Conversation
…once, and contract binding - Add EIP-712 typed data signing with domain separator - Include block.chainid, contract address, and nonce in signed message hash - Add ecrecover zero-address check - Add per-sender nonce tracking - Add Foundry tests covering cross-chain replay, same-chain replay, post-upgrade replay, invalid signature, and EIP-712 verification Closes UnsafeLabs#920
Author
|
Payment address for bounty (USDT TRC20): |
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #920
Summary
Added EIP-712 typed data signing to CrossChainBridge's
processTransferfunction to prevent cross-chain replay attacks. The signed message hash now includesblock.chainid, the contract address, and the transfer nonce. Added ecrecover zero-address check inverifySignature. Created Foundry test suite covering all acceptance criteria.Acceptance Criteria
Tests
Tests added in solidity/test/CrossChainBridge.t.sol using Foundry covering all acceptance criteria.
Payment address (USDT TRC20):
TXjaadYhD579e3bCWKnRFKjRq9RZQL7WNj