fix: normalize metrics, features and registration urls - #397
Merged
Conversation
sighphyre
force-pushed
the
fix/normalize-urls
branch
from
July 24, 2026 07:54
4816151 to
c3a9e16
Compare
for more information, see https://pre-commit.ci
Coverage Report for CI Build 30435144080Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.2%) to 93.428%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ppicom
reviewed
Jul 28, 2026
| @@ -0,0 +1,2 @@ | |||
| def get_url(url: str, path: str) -> str: | |||
Contributor
There was a problem hiding this comment.
nitpick1: Have we considered a more specific name (e.g. normalize_trailing_slash)
get suggests me either a getter from a class or a function that will fetch something over the network
Footnotes
ppicom
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the URL generation code for metrics, registration and features by preventing double slashes in the URL path when the user sets a Unleash server path with a trailing slash