Skip to content

chore: fix duplicated coveralls job on CI - #396

Merged
sighphyre merged 1 commit into
mainfrom
chore/fix-duplicate-coveralls-job
Jul 21, 2026
Merged

chore: fix duplicated coveralls job on CI#396
sighphyre merged 1 commit into
mainfrom
chore/fix-duplicate-coveralls-job

Conversation

@sighphyre

Copy link
Copy Markdown
Member

De duplicates the coveralls job on our CI. Before this patch, this was causing coveralls reports to run twice on every PR, coveralls is not a fan and responds by refusing to serve the duplicated job, forcing the check to never get reported to Github, which in turn blocks CI forever

@irstavr irstavr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 yeee!

@github-project-automation github-project-automation Bot moved this from New to Approved PRs in Issues and PRs Jul 21, 2026
@irstavr
irstavr enabled auto-merge (squash) July 21, 2026 10:15
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29821486574

Coverage remained the same at 93.194%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 764
Covered Lines: 712
Line Coverage: 93.19%
Coverage Strength: 0.93 hits per line

💛 - Coveralls

@chriswk chriswk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighphyre
sighphyre disabled auto-merge July 21, 2026 10:29
@sighphyre
sighphyre merged commit 77d0c4e into main Jul 21, 2026
34 of 42 checks passed
@sighphyre
sighphyre deleted the chore/fix-duplicate-coveralls-job branch July 21, 2026 10:29
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Issues and PRs Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants