Skip to content

add json schemas for topics and services based on json data - #14

Merged
aekber merged 1 commit into
masterfrom
add_schemas_folder
Nov 3, 2026
Merged

aekber merged 1 commit into
masterfrom
add_schemas_folder

Conversation

@aekber

@aekber aekber commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

A new schema folder has been added for shared_variable_update, global_variable_update, modbus_client_signals topics, and set_shared_variables, get_variables services.

@aekber aekber self-assigned this Nov 2, 2026

@urfeex urfeex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment this looks ok to me.

As a side note: I think, sending json data over a string message can be considered a bit of an anti-pattern, as it uses a structured data transfer system to transport structured data (from a different structure) in a string. A more "proper" implementation in my opinion would be to add ROS messages for each of those schemas and have individual publishers for those.

But if the decision is to use the JSON-string instead I see no issue with adding the schemas to this repository, hence approving.

When we ever want to add ROS documentation to this package, we should make sure, the schema ends up in there, as well.

@michal-milkowski

Copy link
Copy Markdown
Member

This is unfortunate result of closed-for-extension design of ros messages. We're aware that we're treating ros as communication channel in this case.
Those messages have to be extendable in the future.

@aekber
aekber merged commit a9683cd into master Nov 3, 2026
1 check passed
@aekber
aekber deleted the add_schemas_folder branch November 3, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants