Repository navigation
add json schemas for topics and services based on json data - #14
Conversation
urfeex
left a comment
There was a problem hiding this comment.
For the moment this looks ok to me.
As a side note: I think, sending json data over a string message can be considered a bit of an anti-pattern, as it uses a structured data transfer system to transport structured data (from a different structure) in a string. A more "proper" implementation in my opinion would be to add ROS messages for each of those schemas and have individual publishers for those.
But if the decision is to use the JSON-string instead I see no issue with adding the schemas to this repository, hence approving.
When we ever want to add ROS documentation to this package, we should make sure, the schema ends up in there, as well.
|
This is unfortunate result of closed-for-extension design of ros messages. We're aware that we're treating ros as communication channel in this case. |
A new schema folder has been added for shared_variable_update, global_variable_update, modbus_client_signals topics, and set_shared_variables, get_variables services.