fix(shopping): add missing error declarations to MCP methods for REST parity#620
Open
prasad-stripe wants to merge 2 commits into
Open
fix(shopping): add missing error declarations to MCP methods for REST parity#620prasad-stripe wants to merge 2 commits into
prasad-stripe wants to merge 2 commits into
Conversation
… parity Committed-By-Agent: claude
damaz91
added
the
status:needs-triage
carolinerg1
added
status:under-review
gov:needs-tc-review
and removed
status:needs-triage
|
Hi @prasad-stripe, thank you for submitting this PR. It looks like the Lint Code Base check is currently failing - could you please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP service definition is missing error declarations that REST already surfaces. Update methods (update_checkout, update_cart) lack idempotency_conflict (REST returns HTTP 409 on PUT). Read methods (get_checkout, get_cart, get_order) lack invalid_params for malformed meta.
This PR adds:
Why this matters
MCP error declarations are the contract agent frameworks use to understand which failures are possible on each method. When declarations are incomplete, agents treat known error conditions as unexpected crashes rather than actionable signals they can recover from (fix params, retry with new idempotency key). REST already surfaces these errors; the MCP spec should declare the same contract.
Test plan