feat: add optional note field to line items#607
Open
hemanth wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @hemanth - thanks for the PR. JFYI - there are two other related PRs at play:
|
17 tasks
Contributor
|
Hello @hemanth ! I see this PR holds changes to files that are probably unrelated to this specific PR. Can you please revert them? Thanks |
Add note (string, maxLength 500) to line_item.json for buyer-supplied per-item instructions (e.g. gift wrapping, dietary preferences, engraving text). - ucp_request: optional on create and update - Business echoes value in responses, MAY forward to fulfillment Closes Universal-Commerce-Protocol#349
hemanth
force-pushed
the
feat/line-item-note
branch
from
July 21, 2026 04:49
c60a798 to
ca39d2d
Compare
Author
|
Ah! Okies @damaz91 /me originally had these changes in one branch and split them into separate PRs, which has brought it side-effects. I have force-pushed the branch so it only touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #349
Summary
Adds an optional
notestring field (max 500 chars) to the line item schema, allowing buyers to attach free-text per-item instructions.Use cases
Changes
source/schemas/shopping/types/line_item.json: Addednoteproperty withmaxLength: 500and appropriateucp_requestannotationsDesign decisions