Skip to content

feat: implement mock AP2 signature verification#26

Closed
0x8000-0000 wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
0x8000-0000:task-ucp-4
Closed

feat: implement mock AP2 signature verification#26
0x8000-0000 wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
0x8000-0000:task-ucp-4

Conversation

@0x8000-0000

Copy link
Copy Markdown
Contributor

Why:

  • To verify that the server correctly rejects invalid AP2 mandates with the appropriate error code.
  • Required for conformance testing of the AP2 security flow.

What:

  • Added 'Ap2VerificationError' to exceptions.
  • Implemented '_verify_ap2_mandate' in 'CheckoutService' to reject mandates containing the substring 'invalid_signature'.
  • Updated 'complete_checkout' to invoke this verification.

Why:
- To verify that the server correctly rejects invalid AP2 mandates with the appropriate error code.
- Required for conformance testing of the AP2 security flow.

What:
- Added 'Ap2VerificationError' to exceptions.
- Implemented '_verify_ap2_mandate' in 'CheckoutService' to reject mandates containing the substring 'invalid_signature'.
- Updated 'complete_checkout' to invoke this verification.
@0x8000-0000
0x8000-0000 requested a review from a team January 17, 2026 00:09
@nearlyforget
nearlyforget requested a review from a team February 28, 2026 03:04
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 7, 2026
@damaz91 damaz91 added status:under-review and removed status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 20, 2026
@damaz91

damaz91 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Closing this as it's outdated post schema version 2026-01-23 and would need to be rewritten from scratch

@damaz91 damaz91 closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants