Skip to content

refactor(nodejs): use @ucp-js/sdk instead of local model generation#139

Merged
damaz91 merged 7 commits into
Universal-Commerce-Protocol:mainfrom
damaz91:issue-62-use-sdk
Jul 22, 2026
Merged

refactor(nodejs): use @ucp-js/sdk instead of local model generation#139
damaz91 merged 7 commits into
Universal-Commerce-Protocol:mainfrom
damaz91:issue-62-use-sdk

Conversation

@damaz91

@damaz91 damaz91 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

Refactors the Node.js sample to use the official @ucp-js/sdk dependency instead of generating models locally. Removes the obsolete generation script and local models.

Category (Required)

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

Fixes #62 and #58

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Refactors the Node.js sample to use the official @ucp-js/sdk dependency instead of generating models locally. Removes the obsolete generation script and local models.

Addresses: Universal-Commerce-Protocol#62
@damaz91 damaz91 added the status:needs-triage Signal that the PR is ready for human triage label Jul 22, 2026
@damaz91
damaz91 marked this pull request as draft July 22, 2026 11:17
damaz91 added 2 commits July 22, 2026 11:32
Update server implementation to use Zod schemas from the SDK for validation, fix fulfillment options mapping, support new discounts, implement free shipping logic, and add completion validation.
@damaz91
damaz91 marked this pull request as ready for review July 22, 2026 12:08
@damaz91 damaz91 added status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Jul 22, 2026
@damaz91
damaz91 merged commit ddc1de0 into Universal-Commerce-Protocol:main Jul 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update the node-js example to use SDK

3 participants