Skip to content

fix: Update fulfilment test to treat [] and None equally.#16

Merged
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
semenovm:handle_empty_list
Jul 20, 2026
Merged

fix: Update fulfilment test to treat [] and None equally.#16
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
semenovm:handle_empty_list

Conversation

@semenovm

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

(Please provide a detailed technical and strategic rationale here for why this
breaking change or removal is necessary.)


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

From business logic perspective empty list and none are equivalent, the test is too strict.

@semenovm
semenovm requested a review from a team January 22, 2026 09:38
@nearlyforget
nearlyforget requested a review from a team February 28, 2026 03:46
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 7, 2026
@damaz91 damaz91 added status:under-review and removed status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 20, 2026
@damaz91
damaz91 force-pushed the handle_empty_list branch from 48dc946 to 682f18e Compare July 20, 2026 10:35
@damaz91
damaz91 removed the request for review from a team July 20, 2026 10:42
@damaz91
damaz91 merged commit 64d8129 into Universal-Commerce-Protocol:main Jul 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants