Add ephemeral container PSS evidence gates#1192
Open
99INFLUENCERS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
container-securitySkill path:
skills/cloud/container-security/What Was Wrong
The skill warned that init/sidecar/ephemeral containers can be missed, but the actionable CIS/PSS workflow and report template did not force reviewers to inventory
spec.ephemeralContainersor collect runtime evidence for thepods/ephemeralcontainerssubresource.That can miss a real Kubernetes debug-container failure mode: a Deployment or Pod can look Restricted-compliant for regular containers, while a later
kubectl debugworkflow injects a privileged ephemeral container into a running production pod.What This PR Fixes
ephemeralContainersand debug manifests to the discovery patterns.containers,initContainers, andephemeralContainersseparately.pods/ephemeralcontainers.Addresses #1191.
Evidence
Before (skill misses this / false positive on this):
A reviewer could score the regular container as Restricted-compliant while missing the privileged debug container.
After (now correctly handled):
The report matrix now records regular, init, and ephemeral container coverage separately.
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Added fixtures:
skills/cloud/container-security/tests/vulnerable/ephemeral-container-privileged.yamlskills/cloud/container-security/tests/benign/ephemeral-container-restricted.yamlValidation run:
git diff --checkskills/**/SKILL.mdandroles/**/SKILL.mdrg -n 'ephemeralContainers|pods/ephemeralcontainers|PSS-EPHEMERAL|Container type|Not Evaluable|version: "1\.1\.0"' skills/cloud/container-securityBounty Tier
Bounty Info
Pull Request Checklist
injection-hardened: trueset in frontmatterallowed-toolsscoped to minimum necessary permissionsindex.yamlupdated with new skill entry (not applicable; existing skill only)What This PR Does
Improves
container-securityso Pod Security Standard reviews explicitly cover ephemeral/debug containers as first-class container surfaces, including static manifest coverage and runtime subresource evidence.Framework References
Testing
git diff --checkskills/**/SKILL.mdandroles/**/SKILL.mdrg -n 'ephemeralContainers|pods/ephemeralcontainers|PSS-EPHEMERAL|Container type|Not Evaluable|version: "1\.1\.0"' skills/cloud/container-security