Add access review certifier independence gates#1164
Open
bozicovichsantiago20-oss wants to merge 1 commit into
Open
Add access review certifier independence gates#1164bozicovichsantiago20-oss wants to merge 1 commit into
bozicovichsantiago20-oss wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: access-review
Skill path:
skills/identity/access-review/What Was Wrong
Issue #1159 shows that the skill treated certification completeness mostly as a decision/evidence problem. It did not require proof that the certifier was independent, authorized, in-scope for delegation, or unable to grant/revoke the same access being certified.
What This PR Fixes
Evidence
Before (skill misses this / false positive on this):
A campaign could look complete even though a privileged user approved their own access.
A delegated reviewer could approve outside the approved system and privilege scope.
After (now correctly handled):
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)git diff --cached --check; fixture files reviewed for simple YAML structure and expected markers.Bounty Tier
Bounty Info
Addresses #1159.