Add entity-normalization evidence to log-analysis correlation#1147
Open
Peter7896 wants to merge 1 commit into
Open
Add entity-normalization evidence to log-analysis correlation#1147Peter7896 wants to merge 1 commit into
Peter7896 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: log-analysis
Skill path:
skills/secops/log-analysis/What Was Wrong
log-analysisalready tells analysts to pivot across users, hosts, IPs, and IOCs, but it does not require evidence showing that source-specific entity fields were normalized before cross-source correlation. A WindowsDOMAIN\\user, Entra ID UPN, EDR short username, SaaS principal ID, NetBIOS hostname, FQDN, and device ID can represent the same entity or different entities. Without a documented join rule and confidence level, the skill can over-link unrelated activity or miss real cross-source behavior.This PR addresses #1142, with emphasis on the entity-normalization portion. It is intended to be complementary to the existing timestamp-focused work in #1053 / #1054 / #1102 by adding normalized user/host keys, parser/schema evidence, and entity join confidence to the analysis workflow and output template.
What This PR Fixes
DOMAIN\\user, UPNs, short usernames, service principals, NetBIOS names, FQDNs, endpoint sensor IDs, and cloud device IDs as separate until an authoritative mapping confirms the join.Source Quality and Normalizationand timeline fields for normalized entity and entity join confidence.Evidence
Before (skill can over-link entities):
[ {"source": "windows", "Account": "ACME\\alice", "Computer": "WS-17", "EventID": 4624}, {"source": "azuread", "UserPrincipalName": "alice@acme.example", "DeviceId": "aad-device-123"}, {"source": "edr", "user.name": "alice", "host.hostname": "ws-17.acme.example"} ]Without a normalization table, an analyst may silently treat all three user and host representations as the same actor/device, or fail to join them when they are actually the same entity.
After (now explicitly handled):
The report template now requires the normalized entity and entity join confidence in the timeline, and weak joins are documented as analysis notes or visibility gaps instead of confirmed findings.
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)git diff --checkcompleted with no whitespace errorsThis repository's current
log-analysisskill is a markdown skill without adjacent test fixture directories onmain, so this PR updates the executable analysis workflow and output template directly.Bounty Tier
Bounty Info