Feature/web3 678 customer screening - #445
Open
CamCompilot wants to merge 36 commits into
Open
Conversation
* Feature/web3 123 docs update example apps documentation (#199) * Minor text style improvements * Minor additions to the readme files * Minor style change * Making README NexeraID specific * Updates following review * Feature/web3 149 redeploy aave pool with new verifier and update aave example (#201) * update proxy pool address * use local env for pool and update idenztity sdk use * NEX-399 - Updated versions of Exmaple Apps and Aave interface (#203) * NEX-399 - Updated versions of Exmaple Apps and Aave interface * NEX-399 - Changing ethers version * NEX-399 - Change api url (#204) * Change by default testnet config on Aave interface (#209) * NEX-438 - Refactored example apps webhook response obtained (#210) * NEX-440 - Updated api prod URL (#211) --------- Co-authored-by: Andrew McFarland Campbell <131174751+AndrewMcFarlandCampbellNexeraID@users.noreply.github.com> Co-authored-by: Antoine Estienne <estienne.antoine@gmail.com> Co-authored-by: Lizandro Zerpa <lizandroal.zerpa@gmail.com> Co-authored-by: Marko Smej <marko.smej@outlook.com>
* Feature/web3 123 docs update example apps documentation (#199) * Minor text style improvements * Minor additions to the readme files * Minor style change * Making README NexeraID specific * Updates following review * Feature/web3 149 redeploy aave pool with new verifier and update aave example (#201) * update proxy pool address * use local env for pool and update idenztity sdk use * NEX-399 - Updated versions of Exmaple Apps and Aave interface (#203) * NEX-399 - Updated versions of Exmaple Apps and Aave interface * NEX-399 - Changing ethers version * NEX-399 - Change api url (#204) * Change by default testnet config on Aave interface (#209) * NEX-438 - Refactored example apps webhook response obtained (#210) * NEX-440 - Updated api prod URL (#211) --------- Co-authored-by: Andrew McFarland Campbell <131174751+AndrewMcFarlandCampbellNexeraID@users.noreply.github.com> Co-authored-by: Antoine Estienne <estienne.antoine@gmail.com> Co-authored-by: Lizandro Zerpa <lizandroal.zerpa@gmail.com> Co-authored-by: Marko Smej <marko.smej@outlook.com>
Signed-off-by: Marko Smej <marko.smej@outlook.com>
Signed-off-by: Marko Smej <marko.smej@outlook.com>
Signed-off-by: Marko Smej <marko.smej@outlook.com>
CamCompilot
requested review from
0xmapachex,
TilenOman50,
acuderman,
bogdancirlugea2,
eveelin,
grmkris,
joelamouche,
kevin-pannetier,
markoftw and
thierry-nexera
as code owners
February 19, 2025 16:51
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joelamouche
reviewed
Feb 19, 2025
joelamouche
approved these changes
Mar 3, 2025
joelamouche
left a comment
Contributor
There was a problem hiding this comment.
components and routes still say customer but otherwise looks good
| @@ -0,0 +1,113 @@ | |||
| ComPilot Customer Screening Example - Backend TypeScript | |||
Contributor
There was a problem hiding this comment.
ya encore ecrit Customer Screening
| * Endpoints: | ||
| * - POST /api/customers: Submit a new customer screening | ||
| */ | ||
| export class CustomerController { |
Contributor
There was a problem hiding this comment.
still customer here, also the endpoitn above is wrong I think
| * Note: These routes are mounted at /api/customers in index.ts | ||
| * So the full path would be /api/customers/ | ||
| */ | ||
| const router = Router(); |
Contributor
There was a problem hiding this comment.
this route should be called individuals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA task url (if applicable)
(If Bug) What was the problem being solved?
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
How to reproduce fix / test this PR?