Made changes suggested by Nina by gitumarkk · Pull Request #29 · Umonya/DjangoWebsite

gitumarkk · 2013-07-22T17:37:27Z

Added google forms and removed registration code.
Made html edits.
Did south migrations.

- Changed string formatting in views.py and form.py - Removed spacing around = in registration.html and contact.html

- Made digits css class in RegistrationForm one word - Made changes to html indenting in contact.html and registration.html - Made changes to send_email_f() in views to have a key, value paring

ninas · 2013-07-22T19:05:40Z

umonya/requirements.txt

alphabetical order.
The South stuff isn't in here?

ninas · 2013-07-23T11:55:40Z

umonya/umonya/apps/main/admin.py

What is Dynamic_Section being used for?

@ninas to check if section is enabled, the menu and the registration page depends on it.

Why can't this functionality be covered in Registration?

@ninas now that the registration form depends only on one field in the django admin, will do that

ninas · 2013-07-23T12:29:48Z

umonya/umonya/templates/contact.html

Not sure where the comment disappeared to.
Ok, so looking closer at this code - your indentation is wrong (if is in the for)
Also, this data is filled in server side - i.e. user hasn't touched this yet, what field.errors are you expecting?

Any reason to use something more than:
{% csrf_token %} {{ form.as_p }}

@ninas I assume that javascript will not be working all the time for all users hence server side validation serves as a back up, I think it provides significant benefits.

So this code is converted into html BEFORE the data is sent to the user's browser to be rendered. I.e. this becomes static html. The fields you're using can be used to display client-side validation errors.
https://docs.djangoproject.com/en/dev/topics/forms/#customizing-the-form-template

You should definitely have server side validation, but this isn't it.

@ninas basically what is happening initially from what I understand when the form gets rendered initially, the errors defaults to false, then as the user is filling in data if any is wrong the javascript catches this error, however if for some reason the javascript is broken i.e. disabled in the browser, form validation is repeated in the views.py file i.e. form.validate() function, if this returns false, the form is re-rendered this time the error defaults to true and the required error message is given (but I could be wrong in that case I will remove it).

Have you tested this functionality?

@ninas it was what was validating the forms before the javascript was introduced, and it is also what is working in the unittests (https://github.com/gitumarkk/DjangoWebsite/blob/develop/umonya/umonya/apps/main/tests/test_forms.py)

a form object is not a valid URL and therefore gives an error

ninas · 2013-07-31T12:37:37Z

umonya/umonya/apps/main/models.py

form_url
Make this a URL field...

Where is the ability to specify registration is open or closed?

@ninas <iframe> causes validation errors and doesn't save in database as I think the URLField is meant for http//: urls If there is no form code in database registration is closed.

All that's going to change is the url - you don't need to include the whole iframe html stuff as well - just change which url is used by the iframe, and store only that. Does that make sense?
Also: http://stackoverflow.com/questions/8778416/what-are-the-valid-values-for-a-django-url-field

gitumarkk added 27 commits June 25, 2013 11:36

Changed to string formatting and spacing around =

b485a13

- Changed string formatting in views.py and form.py - Removed spacing around = in registration.html and contact.html

Did Suggested change (Many changes Sorry Jonathan )

9265a87

- Made digits css class in RegistrationForm one word - Made changes to html indenting in contact.html and registration.html - Made changes to send_email_f() in views to have a key, value paring

Adding captcha

3304a5f

Added django-recaptcha and updated requirements

aaa2771

Added recapture to forms

f9262bd

Made indentation changes suggested by @ninas

bb175fa

Made changes suggested by @ninas

6f4c478

Moved javascript code to separate file

8de1555

Added google forms code to registration page

2712da1

deleted Registration Model

640dbce

Removed registration from forms

9eceb0c

Removed registration from admin

1c37b5d

Edited Registration views rendering

263453f

modifying the JS to account for registration

31ef7ad

modified json data for deleting registration

ccc9e72

Modifying unittests.

ae2ac92

adding comma to captcha

c005570

adding comma to captcha

fab4eb4

Removing captcha keys from form

ff7994b

deleting str() from views

ecae261

adding south to settings

85159db

Added south migrations

264c7fc

fixing typo in contact form

1b2ae18

Removed pub_date from About Model

2ea5b36

created fixture for updated about model

a246a3a

fixed splitting dict

2af4e88

updated unittests to delete pub_date

83c7826

ninas reviewed Jul 22, 2013
View reviewed changes

umonya/requirements.txt Outdated

Copy link

Member

ninas Jul 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order.
The South stuff isn't in here?

gitumarkk added 3 commits July 23, 2013 13:03

Changed grammatical errors in registration form

a049b79

updating registration views to include Model

2c9e94f

Fixing registration views for failing unittests

352ff29

ninas reviewed Jul 23, 2013
View reviewed changes

gitumarkk added 3 commits July 23, 2013 14:14

updating Pillow error in Requirements.txt

eeb7ef5

modifying registration.html

6fcfb16

added URL field to model and did south migration

7daa53e

ninas reviewed Jul 23, 2013
View reviewed changes

gitumarkk added 9 commits July 30, 2013 22:26

having a single form.as_p field

957ce99

adding registration open context processor

b7e6ff6

changing how registration open is being checked

3c5aa6e

removing dynamic section from models.py

a1f6bd2

changing how if registered is checked

5b0ccd1

removing dynamic section from views.py

a305470

removing dynamic section from admin.py

85ca97f

changing URLField to CharField

ecaf74e

a form object is not a valid URL and therefore gives an error

updating unittests for dynamic section deletion

c384919

ninas reviewed Jul 31, 2013
View reviewed changes

Changed False to None

557fc56

Conversation

gitumarkk commented Jul 22, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants