Improve linux compatibility - #113
Merged
Merged
Conversation
The receive path had three defects that mostly showed on Linux, where the event loop drives both reading and writing. - processMatchedReply removed expired callbacks from the list it was iterating, so every second matching callback was skipped and left registered. With four handlers on main.id this dropped the timeout acknowledge and triggered "Timeout. Please reconnect". - A ']' arriving before any '[' made the parser break out of its loop forever. Every later reply piled up behind it and nothing was dispatched again until the port was closed. - A read boundary inside a multibyte character raised in decode() and the whole chunk was discarded, which is what produced those truncated frames. Also stop opening modal dialogs and doing blocking github requests from inside the receive path, clear the OS buffers on open, drop the send buffer on reset and handle QSerialPort errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds simple tests for the communication for now to ensure it keeps working...