Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ultraplot/axes/geo.py
Original file line number Diff line number Diff line change
Expand Up @@ -2139,6 +2139,9 @@ def _add_geoticks(self, x_or_y: str, itick: Any, ticklen: Any) -> None:
for size, which in zip(sizes, ["major", "minor"]):
params.update({"length": size})
params.pop("grid_alpha", None)
# Avoid overriding gridliner label toggles via tick_params defaults.
for key in ("labeltop", "labelbottom", "labelleft", "labelright"):
params.pop(key, None)
self.tick_params(
axis=x_or_y,
which=which,
Expand Down
14 changes: 14 additions & 0 deletions ultraplot/tests/test_geographic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1725,3 +1725,17 @@ def test_boundary_labels_view_intervals():
assert abs(loninterval[0] - 0) < 1 and abs(loninterval[1] - 60) < 1
assert abs(latinterval[0] - (-20)) < 1 and abs(latinterval[1] - 40) < 1
uplt.close(fig)


def test_labels_preserved_with_ticklen():
"""
Ensure ticklen updates do not disable top/right gridline labels.
"""
fig, ax = uplt.subplots(proj="cyl")
ax.format(lonlim=(0, 10), latlim=(0, 10), labels="both", lonlines=2, latlines=2)
assert ax.gridlines_major.top_labels
assert ax.gridlines_major.right_labels

ax.format(ticklen=1, labels="both")
assert ax.gridlines_major.top_labels
assert ax.gridlines_major.right_labels
Loading