Improve scancode selector with tiled category layout - #3048
Merged
Conversation
Replace the scrolling ng-select scancode dropdown with a compact category panel that tiles short labels and keeps incremental search, addressing #2288. Co-authored-by: Cursor <cursoragent@cursor.com>
…hat code Custom entries like B5 were hidden because letter B already maps to basic scancode 5. Offer the tag whenever that exact id is new, and prefer it on Enter. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng-selectscancode dropdown with a dedicatedscancode-selectpanel that lists categories vertically in a narrow, viewport-tall overlay.0–4,5–9, operators,Enter/NumLock).M/B/Sscancode tags; raise overlay z-index so the panel appears above the key-action popover.Closes #2288
Test plan
0–4,5–9,/ * - + .,EnterNumLockmedia,esc) and confirm empty categories disappearM123/B45/S12Made with Cursor