feat: add copy/paste layer support - #2986
Closed
mondalaci wants to merge 2 commits into
Closed
Conversation
…, and toggleable log - Show a determinate per-device progress bar with live percentage during firmware flashing, wired from the mcumgr/kboot write operations through a new moduleFirmwareUpgradeProgress IPC event. - Surface the "connect the left/right half via USB" prompt as a prominent, easily-noticeable warning on the firmware screen via a dedicated IPC signal instead of relying on the update log. - Hide the firmware update log by default and add a Show/Hide toggle that appears once the log has any text. Implements #2593. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds copy and paste buttons to the layer header so a layer can be copied to a virtual clipboard and pasted onto any layer, overwriting it (closes #2692). Paste is safe across keymaps and devices: - macro references are re-linked by name, falling back to a none action - dangling switch-keymap references fall back to a none action - modules are merged by id and key count so a layer copied from a different keyboard or layout can never desync the target's structure Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
superseded by #2992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements copy/paste of layers, as requested in #2692.
?icon). The Paste button appears once a layer has been copied.Cross-context safety
Paste is guarded so it can never produce an invalid configuration:
NoneAction(color preserved).NoneAction(color preserved). This avoids serializing a-1keymap index.SwitchLayerAction, keystroke secondary roles, andConnectionsActionhost-connection references are left untouched — they serialize to fixed/valid values and at worst become semantically "dead" keys until the relevant layer/connection exists (no corruption).Notes
Test plan
Made with Cursor