Use buffer sizes for pyProject span validation - #17
Draft
HellAholic wants to merge 2 commits into
Draft
Conversation
Replaced strict 2D `ndim` checks with stride-based element-count validation in `pyProject`, ensuring each input buffer size is divisible by its struct width (2 or 3). Span lengths are now derived from total element counts (`size / stride`) instead of `shape[0]`, allowing compatible flattened buffers while keeping matrix and camera-normal size checks intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced strict 2D
ndimchecks with stride-based element-count validation inpyProject, ensuring each input buffer size is divisible by its struct width (2 or 3). Span lengths are now derived from total element counts (size / stride) instead ofshape[0], allowing compatible flattened buffers while keeping matrix and camera-normal size checks intact.