CURA-13243 center dialogs on linux - #1046
Open
Erwan MATHIEU (wawanbreton) wants to merge 2 commits into
Open
Conversation
CURA-13243
CURA-13243
Test Results2 404 tests 2 389 ✅ 20s ⏱️ Results for commit ff71881. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the update to Qt 6.10, dialogs don't appear centered on Linux environment. Since this should really happen natively, I found no other way but to actually set the window position manually.
An other solution would be to have
UM.Dialoguse aQtQuick.Controls.Dialoginstead of aQtQuick.Controls.Window, which fixes the centering, but that leads to other issues such at not being able to set a minimum size.CURA-13243