[UC-3697] Format C++ codebase and fix formula evaluation and parsing - #8
Open
Jelle Spijker (jellespijker) wants to merge 1 commit into
Open
[UC-3697] Format C++ codebase and fix formula evaluation and parsing#8Jelle Spijker (jellespijker) wants to merge 1 commit into
Jelle Spijker (jellespijker) wants to merge 1 commit into
Conversation
3 tasks
Jelle Spijker (jellespijker)
force-pushed
the
UC-3697-cpp-fixes-and-formatting
branch
from
August 20, 2026 08:30
648688f to
0001219
Compare
Jelle Spijker (jellespijker)
changed the base branch from
main
to
UC-3697_AI_DF
August 20, 2026 08:31
3 tasks
Jelle Spijker (jellespijker)
force-pushed
the
UC-3697-cpp-fixes-and-formatting
branch
from
August 20, 2026 08:34
0001219 to
985db88
Compare
Jelle Spijker (jellespijker)
marked this pull request as ready for review
August 20, 2026 08:38
Apply standard clang-format code formatting across all C++ headers, source files, apps, and tests. In addition, resolve syntax and AST evaluation errors: - Restore Value::numeric() and Emscripten conversion handling in src/eval.cpp - Remove duplicate arguments and bindings in src/ast/fn_application_expr.cpp - Fix evaluation loop and membership checks in src/ast/comp_chain_expr.cpp - Restore clean function definitions in src/env/math_log.cpp and src/env/min.cpp - Remove duplicate grammar struct definitions in variable_or_fn_application_grammar_or_array_indexing_grammar.h - Enable CTest test discovery when building unit tests in CMakeLists.txt Contributes to UC-3697
HellAholic
force-pushed
the
UC-3697-cpp-fixes-and-formatting
branch
from
August 20, 2026 08:48
985db88 to
ff13730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR (Layer 2 of Stack) containing foundational C++ code formatting and formula test execution wiring.
Base layer: #10 (
UC-3697_AI_DF)Why
Extracted from the agentic enablement PR as a dedicated boy-scouting PR to separate C++ code formatting and CTest discovery from the Quad-Agent configuration scaffolding.
What
include(CTest)insideif (ENABLE_TESTS)afterBUILD_TESTINGenablement inCMakeLists.txtso Catch2 tests are properly discovered and registered with CTest.src/eval.cpp,src/ast/comp_chain_expr.cpp,src/ast/fn_application_expr.cpp,src/env/math_log.cpp,src/env/min.cpp, etc.) using.clang-format.How
.agents/rules/08-scoped-changes-and-minimal-diffs.md).UC-3697_AI_DF).Verification & Validation (V&V)
1. Catch2 Unit Tests
ctest --preset conan-release --output-on-failure # ==> 158 / 158 tests passed (100%)2. Pre-Commit Validation
pre-commit run --all-files # ==> 19 / 19 hooks passed cleanlyPR Checklist