CURA-13297 Fix wall thickness instead of walls count - #2367
Merged
Conversation
Pass the infill wall distance (wall count × wall width) to `generateWallToolPaths` instead of the raw wall count. This Should correct the extra infill wall generation where the function expects a width-based value in coordinate units.
Update `wall_line_count` in `TreeSupportUtils` to use `coord_t` and compute roof walls in width units (`support_roof_wall_count * support_roof_line_width`) instead of a raw line count. This keeps wall sizing consistent between regular support walls and roof walls and avoids unit/type mismatch.
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit 0374fcb. ♻️ This comment has been updated with latest results. |
HellAholic
approved these changes
Aug 27, 2026
HellAholic
left a comment
HellAholic
left a comment
Contributor
There was a problem hiding this comment.
Changes on branch done by HellAholic and review and PR done by Erwan MATHIEU (@wawanbreton)
LGTU!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the changes for the tree support dynamic wall thickness, some methods now need to properly handle either a wall count or a thickness. This PR fixes a few cases where they were mismatched.
On behalf of HellAholic
CURA-13297