Display engine plugins in gcode - #2364
Merged
Merged
Conversation
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit 996da95. ♻️ This comment has been updated with latest results. |
Casper Lamboo (casperlamboo)
left a comment
Casper Lamboo (casperlamboo)
left a comment
Contributor
There was a problem hiding this comment.
NPM package is failing, I believe we should add #ifdef ENABLE_PLUGINS blocks
CURA-11212 Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Casper Lamboo (casperlamboo)
approved these changes
Aug 18, 2026
Remco Burema (rburema)
previously requested changes
Aug 18, 2026
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
I've got some remarks. I'd be willing to accept as-is if you can explain though :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the list of active engine plugins in the generated gcode. Syntax is based on the post-processing plugins: https://github.com/Ultimaker/Cura/blob/05e2c8937da42b48f8502f3ac69bcf8ed44b7307/plugins/PostProcessingPlugin/PostProcessingPlugin.py#L94
Result is something like:
CURA-11212