[CURA-13265] Fix infill (wall) overlap for infill-support.

[Remco Burema (rburema)]

Wall-width is already taken into account (but maybe not at the time of writing?), so when subtracting half a wall-width over that, it made it seem like the infill overlap setting wasn't working properly.

[github-actions]

Test Results

31 tests   31 ✅  4s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 106f614.

♻️ This comment has been updated with latest results.

[Erwan MATHIEU (wawanbreton)]

Nice, that should improve adhesion between the skin support and the outer walls.
Sorry for the mistake 😅
When thinking about it though, I probably did that to avoid the protrusion of the infill into the outer walls. HellAholic could you make a test print as part of QA to check the quality ?

[Remco Burema (rburema)]

Erwan MATHIEU (@wawanbreton) Don't worry about it!

Also, if the quality is a problem, we should change that with parameters I think. Worst case, we can split it out to a new one.

[Erwan MATHIEU (wawanbreton)]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: 9a6c743	Previous: fbf37fc	Ratio
InfillTest/Infill_generate_connect/0/400	5.804878534799016 ms/iter	3.648410709524255 ms/iter	1.59
HolesWallTestFixture/InsetOrderOptimizer_getInsetOrder/3	0.0002625348999732111 ms/iter	0.00017382738462409593 ms/iter	1.51
HolesWallTestFixture/InsetOrderOptimizer_getInsetOrder/9999	0.011970930861527649 ms/iter	0.007572545422304867 ms/iter	1.58
SimplifyTestFixture/simplify_slot_noplugin	3.789785515326669 ns/iter	2.1604040436005425 ns/iter	1.75

This comment was automatically generated by workflow using github-action-benchmark.

CC: Jelle Spijker (@jellespijker) Erwan MATHIEU (@wawanbreton) Casper Lamboo (@casperlamboo) HellAholic

[HellAholic]

Nice, that should improve adhesion between the skin support and the outer walls. Sorry for the mistake 😅 When thinking about it though, I probably did that to avoid the protrusion of the infill into the outer walls. HellAholic could you make a test print as part of QA to check the quality ?

Before:

After:

Using lightning infill and 0.04mm infill overlap (PLA-0.2mm)