Repository navigation
fix(maestro-case): enforce two documented-but-unverified build gates (Check 14 + Check 15) #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d3d818
fix(maestro-case): halt on a surviving placeholder connector-rule stub
roberts-cliff 189c832
test(maestro-case): unit-test the Check 14 grader against synthetic s…
roberts-cliff d7b2c67
fix(maestro-case): Check 14 is the halt point — "must not ship" is no…
roberts-cliff b5b2144
fix(maestro-case): gate Phase 5 on a non-empty issue log (Step 12.2 /…
roberts-cliff 985e957
Merge origin/main; renumber this branch's gates to Check 15 + Check 16
roberts-cliff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No non-interactive path, and this PR ships a task that can't take the interactive one. Check 14 directly above has an explicit Non-interactive repair:; so do 6, 7, 10, 11, 13. Rule 11, Rule 17,
registry-discovery.md§ 1b,connector-integration.md§ 4 andphased-execution.mdall define non-interactive fallbacks. This is the only halting check without one.experiments/default.yamldoesn't grantAskUserQuestion, andcontext_scale_claim_settlement.yamlin this PR both omits it fromallowed_toolsand says "Do NOT call AskUserQuestion" — while its own description notes the design nondeterminism that decides whether the withdrawal path becomes await-for-connectorrule at all. Some runs land here with no defined behavior.Cheapest fix is naming (c) the non-interactive default: abort, leave
caseplan.json, write theBLOCKED:marker. That's already what the marker is for.