tests/tasks/uipath-planner/_shared/check_credit_analyst_gate.py:11 gates case_design_loan and case_finalize_draft_loan. Its threshold pattern carries the optional $ inside the first alternative only, so the numeric form can never be preceded by one.
- THRESHOLD = r"(?:\$?\s*5\s*(?:m(?:illion)?|million)\b|5,?000,?000\b)"
+ THRESHOLD = r"\$?\s*(?:5\s*(?:m(?:illion)?|million)\b|5,?000,?000\b)"
| phrasing |
current |
fixed |
greater than $5,000,000 |
✗ |
✓ |
> $5,000,000 |
✗ |
✓ |
in excess of $5,000,000 |
✗ |
✓ |
greater than 5,000,000 |
✓ |
✓ |
over $5M |
✓ |
✓ |
above $5 million |
✓ |
✓ |
Impact. Nightly 2026-09-11_04-17-19 (gpt-5.6-terra, skill-case-phase-0-loan-origination, 0.89) wrote this in its SDD:
If requestedAmount is greater than $5,000,000, assign Complete Credit Underwriting to the Credit Analyst; otherwise assign it to the Underwriter.
Role, threshold, direction and an executable verb in one clause — reported as FAIL: no executable high-side Credit Analyst gate ties the role to loans over $5M. phase-0-loan-origination has been red on most September nightlies across four models, and this accounts for at least part of it: the design was correct and the checker could not see it.
Ready to take. Branch fix/credit-analyst-threshold-dollar on the remote has the one-line change plus tests/scripts/test_credit_analyst_gate_threshold.py — six positive phrasings, the verbatim nightly clause, and three negatives asserting the direction, role and execution-signal requirements still fail. Reverting the one-line change turns two of those cases red. Opened as #3253 and closed unmerged only because the path is owned by @abhiram-vad @charlesliu9 @song-zhao-25 @jundayin; reopen a PR from that branch or cherry-pick it.
cc @abhiram-vad @charlesliu9 @song-zhao-25 @jundayin
🤖 Generated with Claude Code
tests/tasks/uipath-planner/_shared/check_credit_analyst_gate.py:11gatescase_design_loanandcase_finalize_draft_loan. Its threshold pattern carries the optional$inside the first alternative only, so the numeric form can never be preceded by one.greater than $5,000,000> $5,000,000in excess of $5,000,000greater than 5,000,000over $5Mabove $5 millionImpact. Nightly
2026-09-11_04-17-19(gpt-5.6-terra,skill-case-phase-0-loan-origination, 0.89) wrote this in its SDD:Role, threshold, direction and an executable verb in one clause — reported as
FAIL: no executable high-side Credit Analyst gate ties the role to loans over $5M.phase-0-loan-originationhas been red on most September nightlies across four models, and this accounts for at least part of it: the design was correct and the checker could not see it.Ready to take. Branch
fix/credit-analyst-threshold-dollaron the remote has the one-line change plustests/scripts/test_credit_analyst_gate_threshold.py— six positive phrasings, the verbatim nightly clause, and three negatives asserting the direction, role and execution-signal requirements still fail. Reverting the one-line change turns two of those cases red. Opened as #3253 and closed unmerged only because the path is owned by @abhiram-vad @charlesliu9 @song-zhao-25 @jundayin; reopen a PR from that branch or cherry-pick it.cc @abhiram-vad @charlesliu9 @song-zhao-25 @jundayin
🤖 Generated with Claude Code