Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to documentation and deprecation metadata, with no runtime behavior changes or unresolved findings.
No open issues 🎉
What changed in this PR
Deprecates exclusion-based runtime constraints in Apollo React’s node manifest schema, encouraging explicit include lists so nodes are not automatically enabled in future runtimes.
Changes:
- Updates schema documentation to recommend
include. - Adds
@deprecateddocumentation toexcludewhile preserving existing validation and runtime compatibility.
| File | Description |
|---|---|
packages/apollo-react/src/canvas/schema/node-definition/node-manifest.ts |
Documents the exclude deprecation and its rationale without changing validation logic. |
Review effort: Balanced
Dependency License Review
License distribution
Excluded packages
|
… include
A node with { exclude: [...] } is available in every runtime added later,
so each new runtime forces a manifest update to opt the node back out.
The exclude variant is now marked @deprecated and the schema docs point
to include. Existing manifests still parse.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b8ef47c to
c1db00b
Compare
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Storybook visual diffBaseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs Updated (PT): Oct 23, 2026, 07:07:40 AM |
Summary
A node manifest with
runtimeConstraints: { exclude: [...] }is available in every runtime that ships later. Each new runtime then forces a manifest update just to opt the node back out.includedoesn't have this problem, because a new runtime gets no node until a manifest lists it.This PR marks the
excludevariant ofnodeRuntimeConstraintsManifestSchemaas@deprecatedand points the schema docs toinclude.Impact
excludestill parse, so nothing breaks at runtime.constraints.excludethrough the exportedRuntimeConstraintstype shows a deprecation strike-through in the editor, with the reason.excludeis left for a later major release, after the manifests move toinclude.Verification
'exclude' is deprecated(6385) when it readsc.exclude, and nothing when it readsc.include.tsc --noEmitreports 0 errors, Biome is clean, and the 15 schema tests pass.🤖 Generated with Claude Code