Repository navigation
fix(apollo-react): announce Toolbox row details and submenus [MST-14409] [MST-14937] - #1459
Conversation
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
🟡 Changes recommended
Keyboard-active tooltips ignore close requests and can remain visible alongside another row’s hovered tooltip.
1 open issue
What changed in this PR
Improves accessibility in the canvas Toolbox’s “Add node” list while preserving its combobox and listbox navigation pattern.
Changes:
- Adds accessible row descriptions combining tooltip details and submenu availability.
- Opens tooltips for keyboard-active rows.
- Adds tests for descriptions, submenu hints, and initial tooltip visibility.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/locales/en.json | Adds the “Has submenu” translation entry. |
| packages/apollo-react/src/canvas/components/Toolbox/ListView.tsx | Adds accessible descriptions and keyboard-active tooltips. |
| packages/apollo-react/src/canvas/components/Toolbox/ListView.test.tsx | Tests row descriptions and tooltip open props. |
Review effort: Balanced
045787d to
2625357
Compare
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
2625357 to
3bf1c5d
Compare
3bf1c5d to
727d567
Compare
562902a to
7f2222f
Compare
7f2222f to
33e7ce0
Compare
33e7ce0 to
755fd9f
Compare
Storybook visual diffBaseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs Updated (PT): Oct 23, 2026, 01:15:43 AM |


Description
Fixes two Deque findings on the Flow "Add node" panel (Toolbox).
MST-14409: tooltip content not available to screen readers. Rows get virtual focus through
aria-activedescendantand the tooltip opens only on hover, sodetail(tooltip-only text)never reached assistive tech or keyboard users.
aria-describedbyat ahiddenspan holding itsdetail. Nothing changes visually.tooltips stay closed. Toolbox sets
keyboardNavon any key in the search box and clears it onpointer movement over the panel, so mouse use (including a Back click) behaves as before.
MST-14937: submenu availability not announced. Rows with
childrenshowed only a visual chevron.toolbox.item.submenu) to the same description.(
toolbox.category.announcement, e.g. "Agent, 12 items"). It stays empty while searching orwhile the panel or category is loading.
a menu cannot contain the search input, and drill-in replaces the list rather than opening a
submenu beside its parent, so
aria-expandedcould never be true on a visible row.Testing
ListView: the row description combinesdetailand the submenu hint.Toolbox: ArrowDown opens the active row's tooltip and pointer movement closes it; the ArrowRightdrill-in test checks the announcement; the
childrenLoadingdrill-in test checks it stays empty.tscclean.