Skip to content

feat(apollo-wind): warning severity for FormFieldError [MST-17134] - #1446

Merged
BenGSchulz merged 2 commits into
feat/ai-assist-host-contentfrom
feat/form-field-warning
Oct 23, 2026
Merged

BenGSchulz merged 2 commits into
feat/ai-assist-host-contentfrom
feat/form-field-warning

Conversation

@BenGSchulz

@BenGSchulz BenGSchulz commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A warning-level field message for a value that is accepted but likely wrong, such as a reference that no longer resolves (MST-17134).

FormFieldError takes severity?: 'error' | 'warning'. A warning uses the warning token and carries data-severity="warning". It keeps the polite live region and no role, so it is not announced as an error. The control should point aria-describedby at it, not aria-errormessage, and stay valid. Without severity the rendered error is unchanged, classes included.

Decisions worth a look

  • A severity prop rather than a sibling FormFieldWarning. Four spacing rules find the message by data-slot="form-field-error": apollo-wind's FormField, QuickFormField and JsonContainerEditor, and apollo-react's PanelField. A sibling component would need a second slot added to each of them.

Test plan

  • apollo-wind: 2,989 tests pass on the tip of the stack, typecheck clean, Biome clean on changed files. The only failures were 11 in a stale local field-renderer snapshot that is not checked in.
  • FormFieldError: a warning uses the warning token, keeps the slot and polite announcement, and has no role; an error carries no severity attribute
  • Storybook: Form Field "Warning"

Stack

  1. feat(apollo-wind): host-rendered variable picker for Insert variable and Variable mode [MST-17134] #1444: Host-rendered variable picker
  2. feat(apollo-wind): host-rendered content for AI assist [MST-17134] #1445: Host-rendered content for AI assist
  3. feat(apollo-wind): warning severity for FormFieldError [MST-17134] #1446: Warning severity for FormFieldError ← this PR

severity="warning" uses the warning token for a value that is accepted but likely wrong. It
keeps the form-field-error slot, so every field stack's spacing rule still applies, and it is
announced politely rather than as an error.
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 22, 2026 01:26 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 22, 2026 01:26 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 22, 2026 01:26 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 22, 2026 01:26 Destroyed
@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1957 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1721
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@BenGSchulz
BenGSchulz added this pull request to stack #1447 October 22, 2026 01:35
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.02 MB 50.17 MB ±0
@uipath/apollo-react 58.4% 70.4% (19/27) 8.14 MB 32.17 MB −1 B
@uipath/apollo-ui-icons — — 2.86 MB 6.97 MB ±0
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind 79.5% 100.0% (2/2) 814.7 KB 4.70 MB +4.0 KB
@uipath/ap-chat 85.8% — 40.42 MB 45.71 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@BenGSchulz
BenGSchulz marked this pull request as ready for review October 23, 2026 17:36
Copilot AI balanced review requested due to automatic review settings October 23, 2026 17:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions github-actions Bot added the size:M 30-99 changed lines. label Oct 23, 2026
Nothing in wind read the optional item: VariableValueControl and the form's Insert variable
only write the reference, and a host rendering its own picker already knows what it picked.
VariablePicker still makes an entry from the value for onSelect and onInsert.
Copilot AI balanced review requested due to automatic review settings October 23, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 23, 2026 19:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 23, 2026 19:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 23, 2026 19:36 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 23, 2026 19:36 Destroyed
@github-actions github-actions Bot added size:L 100-499 changed lines. and removed size:M 30-99 changed lines. labels Oct 23, 2026
@BenGSchulz
BenGSchulz merged commit e76462f into main Oct 23, 2026
39 of 41 checks passed
@BenGSchulz
BenGSchulz deleted the feat/form-field-warning branch October 23, 2026 20:14

This branch was successfully deployed

No deployments
preview/apollo-vertex — 86fdd143 Deployed Oct 23, 2026 by github-actions[bot]
preview/apollo-landing — 86fdd143 Deployed Oct 23, 2026 by github-actions[bot]
preview/apollo-docs — 86fdd143 Deployed Oct 23, 2026 by github-actions[bot]
preview/apollo-design — 86fdd143 Deployed Oct 23, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-wind size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants