Repository navigation
feat(apollo-wind): warning severity for FormFieldError [MST-17134] - #1446
Merged
Merged
Conversation
severity="warning" uses the warning token for a value that is accepted but likely wrong. It keeps the form-field-error slot, so every field stack's spacing rule still applies, and it is announced politely rather than as an error.
This was referenced Oct 22, 2026
Contributor
Dependency License Review
License distribution
Excluded packages
|
Contributor
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
BenGSchulz
marked this pull request as ready for review
October 23, 2026 17:36
rahul-sharma-uipath
approved these changes
Oct 23, 2026
Nothing in wind read the optional item: VariableValueControl and the form's Insert variable only write the reference, and a host rendering its own picker already knows what it picked. VariablePicker still makes an entry from the value for onSelect and onInsert.
rahul-sharma-uipath
approved these changes
Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A warning-level field message for a value that is accepted but likely wrong, such as a reference that no longer resolves (MST-17134).
FormFieldErrortakesseverity?: 'error' | 'warning'. A warning uses thewarningtoken and carriesdata-severity="warning". It keeps the polite live region and norole, so it is not announced as an error. The control should pointaria-describedbyat it, notaria-errormessage, and stay valid. Withoutseveritythe rendered error is unchanged, classes included.Decisions worth a look
severityprop rather than a siblingFormFieldWarning. Four spacing rules find the message bydata-slot="form-field-error": apollo-wind'sFormField,QuickFormFieldandJsonContainerEditor, and apollo-react'sPanelField. A sibling component would need a second slot added to each of them.Test plan
field-renderersnapshot that is not checked in.FormFieldError: a warning uses the warning token, keeps the slot and polite announcement, and has no role; an error carries no severity attributeStack