Skip to content

fix(apollo-vertex): keep docs examples within mobile viewports - #1386

Merged
ruudandriessen merged 1 commit into
mainfrom
fix/vertex-docs-mobile-overflow
Oct 16, 2026
Merged

ruudandriessen merged 1 commit into
mainfrom
fix/vertex-docs-mobile-overflow

Conversation

@ruudandriessen

Copy link
Copy Markdown
Collaborator

Summary

Three docs examples overflowed a 390px viewport (lintapple finding).

  • Tabs: w-[400px] to w-full max-w-[400px] (was 51px page overflow)
  • Aspect ratio: w-[450px] to w-full max-w-[450px] (was 101px overflow)
  • Carousel: the arrows sit 48px outside the slide (shadcn default -left-12/-right-12). The preview frame now gets px-14 so the arrows stay inside it, and the max-w-xs carousel shrinks to fit. The component itself is unchanged.

The usage code blocks on these pages do not include these classes, so there was nothing to keep in sync. Docs-only change, no package release needed.

Verification

Ran the docs app and measured with Playwright:

  • 390px: scrollWidth == clientWidth (390) on all three pages, carousel arrows at x 25 to 365.
  • 1280px: tabs still 400px wide, aspect ratio still 450px, no overflow.

biome format and oxlint --type-aware pass for apps/apollo-vertex.

Note: no apollo-vertex label exists in the repo, so none was added.

The tabs (w-[400px]) and aspect-ratio (w-[450px]) examples used fixed widths
that pushed the page 51px and 101px wider than a 390px viewport. They now use
w-full with a max width, keeping the desktop size and shrinking on narrow screens.

The carousel arrows sit 48px outside the slide (shadcn default). The preview
frame now has px-14 so the arrows stay inside it, and the max-w-xs carousel
shrinks to fit on narrow viewports. The component positioning is unchanged.
@ruudandriessen
ruudandriessen requested a review from a team as a code owner October 16, 2026 11:42
@ruudandriessen
ruudandriessen requested review from KokoMilev and alincadariu and a balanced review from Copilot October 16, 2026 11:42
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 16, 2026 11:42 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 16, 2026 11:42 Destroyed
@github-actions github-actions Bot added the size:XS 0-9 changed lines. label Oct 16, 2026
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 16, 2026 11:42 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 16, 2026 11:42 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to documentation layout and have no identified blocking issues.

0 open findings

What changed in this PR

Keeps Apollo Vertex documentation previews within mobile viewports without changing component implementations.

Changes:

  • Makes tabs and aspect-ratio examples responsive while preserving maximum widths.
  • Adds carousel preview padding to accommodate navigation arrows.
File Description
apps/​apollo-vertex/​content/​docs/​components/​tabs.mdx Allows tabs to shrink below 400px.
apps/​apollo-vertex/​content/​docs/​components/​carousel.mdx Reserves space for carousel arrows.
apps/​apollo-vertex/​content/​docs/​components/​aspect-ratio.mdx Allows the example to shrink below 450px.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1947 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1713
ISC 91
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-vertex — — 325.9 KB 1.84 MB +1 B
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No stories are affected by this PR's changes; nothing to compare. Logs

Updated (PT): Oct 16, 2026, 04:52:44 AM

@ruudandriessen
ruudandriessen merged commit e66f744 into main Oct 16, 2026
44 of 45 checks passed
@ruudandriessen
ruudandriessen deleted the fix/vertex-docs-mobile-overflow branch October 16, 2026 12:11

This branch was successfully deployed

No deployments
preview/apollo-landing — 7f69a47d Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-design — 7f69a47d Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-vertex — 7f69a47d Deployed Oct 16, 2026 by github-actions[bot]
preview/apollo-docs — 7f69a47d Deployed Oct 16, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants