Repository navigation
fix(apollo-vertex): keep docs examples within mobile viewports - #1386
Conversation
The tabs (w-[400px]) and aspect-ratio (w-[450px]) examples used fixed widths that pushed the page 51px and 101px wider than a 390px viewport. They now use w-full with a max width, keeping the desktop size and shrinking on narrow screens. The carousel arrows sit 48px outside the slide (shadcn default). The preview frame now has px-14 so the arrows stay inside it, and the max-w-xs carousel shrinks to fit on narrow viewports. The component positioning is unchanged.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to documentation layout and have no identified blocking issues.
0 open findings
What changed in this PR
Keeps Apollo Vertex documentation previews within mobile viewports without changing component implementations.
Changes:
- Makes tabs and aspect-ratio examples responsive while preserving maximum widths.
- Adds carousel preview padding to accommodate navigation arrows.
| File | Description |
|---|---|
| apps/apollo-vertex/content/docs/components/tabs.mdx | Allows tabs to shrink below 400px. |
| apps/apollo-vertex/content/docs/components/carousel.mdx | Reserves space for carousel arrows. |
| apps/apollo-vertex/content/docs/components/aspect-ratio.mdx | Allows the example to shrink below 450px. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependency License Review
License distribution
Excluded packages
|
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
Storybook visual diff✅ No stories are affected by this PR's changes; nothing to compare. Logs Updated (PT): Oct 16, 2026, 04:52:44 AM |
Summary
Three docs examples overflowed a 390px viewport (lintapple finding).
w-[400px]tow-full max-w-[400px](was 51px page overflow)w-[450px]tow-full max-w-[450px](was 101px overflow)-left-12/-right-12). The preview frame now getspx-14so the arrows stay inside it, and themax-w-xscarousel shrinks to fit. The component itself is unchanged.The usage code blocks on these pages do not include these classes, so there was nothing to keep in sync. Docs-only change, no package release needed.
Verification
Ran the docs app and measured with Playwright:
scrollWidth == clientWidth(390) on all three pages, carousel arrows at x 25 to 365.biome formatandoxlint --type-awarepass forapps/apollo-vertex.Note: no
apollo-vertexlabel exists in the repo, so none was added.