Repository navigation
fix(apollo-vertex): use type scale sizes in calendar and timeline - #1385
Conversation
Calendar weekday headers and week numbers used text-[0.8rem] (12.8px) and the compact timeline user marker used text-[9px], both outside the type scale. Move them to text-xs (12px). Two initials at 12px do not fit the 16px compact marker, so the compact user marker now shows only the first initial instead of shrinking the text below the scale or growing every compact marker.
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
🟡 Changes recommended
Compact initial truncation splits supplementary Unicode characters and displays replacement glyphs.
1 open finding
What changed in this PR
Aligns calendar and timeline typography with the Apollo Vertex type scale.
Changes:
- Uses
text-xsfor calendar weekday headers and week numbers. - Uses
text-xsand one initial for compact user markers. - Documents compact initial behavior.
| File | Description |
|---|---|
| packages/apollo-vertex/registry/timeline/timeline-marker.tsx | Updates compact marker typography and initials. |
| packages/apollo-vertex/registry/calendar/calendar.tsx | Replaces off-scale font sizes. |
| apps/apollo-vertex/content/docs/components/timeline.mdx | Documents single-character compact markers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Storybook visual diff✅ No stories are affected by this PR's changes; nothing to compare. Logs Updated (PT): Oct 16, 2026, 04:51:01 AM |
What
text-[0.8rem](12.8px) totext-xs(12px). Only those two classes change; the rest of the shadcn sync and the Apollo customizations stay as they are.usermarker goes fromtext-[9px]totext-xs, and now shows only the first initial.initialsprop row intimeline.mdxnow says that the compact size shows one character.Why
Both sizes were outside the type scale (12, 14, 16, 18, 20, 24, 30px). Neither spot needs a new size, so both move to
text-xs.The compact marker is a 16px circle (
size-4). Two medium-weight initials at 12px ("PV" is about 15px wide) fill the whole circle and spill past its curved edge. I looked at two fixes:size-5(20px). This changes all nine compact variants and how the icon and AiMark sit inside them, which is a bigger visual change than this lint fix needs.Trade-off: the compact marker no longer shows the second initial. If design prefers option 2, it's a small follow-up.
How verified
In
packages/apollo-vertex:pnpm lint(oxlint type-aware),pnpm typecheck,pnpm testandbiome formatall pass. No changeset is needed: the repo has no.changesetdirectory, and releases follow conventional commits.