Skip to content

ci(repo): report Coded App deployments as GitHub Deployments - #1366

Merged
ruudandriessen merged 1 commit into
mainfrom
t3/use-github-deployments
Oct 16, 2026
Merged

ruudandriessen merged 1 commit into
mainfrom
t3/use-github-deployments

Conversation

@ruudandriessen

@ruudandriessen ruudandriessen commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

TLDR: use github deployments instead of a PR comment, it's much nicer 😄

From this:
image

To this:
image


Coded App preview URLs were posted in a PR comment table that two extra jobs kept up to date. They now show up as GitHub Deployments, in the PR timeline and the merge box, and production deploys on main report the same way.

Previews: each matrix leg creates a deployment in preview/<app> for the PR head commit, tagged with a per-PR task. It shows as in progress with a link to the run, then success with the preview URL, or failure. Deployments are marked transient_environment so a deploy from another PR doesn't mark this PR's preview inactive. Closing the PR marks its deployments inactive. The comment jobs and script are removed, and only the apollo-design leg still uploads a result artifact, for the visual-diff job.

Production: now runs as a per-app matrix using the job-level environment: production/<app> key with the app URL, instead of four sequential deploys in one job. Turbo cache keys are now per app.

Testing limits: not run yet; actionlint wasn't available locally. On this PR, check that each app's preview appears as a deployment, and that two PRs' previews both stay active. Merging will first create the production/* environments.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:47
@github-actions github-actions Bot added the ci label Oct 13, 2026
@github-actions
github-actions Bot had a problem deploying to preview/apollo-landing October 13, 2026 15:47 Error
@github-actions github-actions Bot added the size:L 100-499 changed lines. label Oct 13, 2026
@ruudandriessen
ruudandriessen force-pushed the t3/use-github-deployments branch from 21dd706 to df28921 Compare October 13, 2026 15:48
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1942 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1708
ISC 91
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Mutable-ref handling can misattribute deployments and leave older PR deployments active after closure.

1 open finding
What changed in this PR

Moves Coded App reporting from PR comments to GitHub Deployments for preview and production environments.

Changes:

  • Adds per-app preview deployment statuses and cleanup.
  • Parallelizes production deployments by app.
  • Removes the legacy preview-comment implementation.
File Description
.github/​workflows/​production-deploy.yml Adds per-app production environments and matrix deployment.
.github/​workflows/​preview-deploy.yml Creates, finishes, and deactivates preview deployments.
.github/​scripts/​preview-deploy/​preview-comment.mjs Removes obsolete comment-table handling.
.github/​scripts/​preview-deploy/​deployments.mjs Implements GitHub Deployment API helpers.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/scripts/preview-deploy/deployments.mjs Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:50
@ruudandriessen
ruudandriessen force-pushed the t3/use-github-deployments branch from df28921 to af94f88 Compare October 13, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Production deployment orchestration and deployment lifecycle behavior require the stated live workflow validation before approval.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:53
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 13, 2026 15:53 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 13, 2026 15:53 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 13, 2026 15:53 Destroyed
@ruudandriessen
ruudandriessen marked this pull request as ready for review October 13, 2026 15:53
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 13, 2026 15:53 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Previous same-PR deployments remain active, and a Vertex-only credential can incorrectly fail every production matrix leg.

2 open findings

🧠 Review effort: Balanced

Comment thread .github/workflows/production-deploy.yml
Comment thread .github/scripts/preview-deploy/deployments.mjs
Copilot AI balanced review requested due to automatic review settings October 13, 2026 16:00
@ruudandriessen
ruudandriessen force-pushed the t3/use-github-deployments branch from af94f88 to 521d9c1 Compare October 13, 2026 16:00
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 13, 2026 16:01 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 13, 2026 16:01 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 13, 2026 16:01 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 13, 2026 16:01 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

PR-controlled code receives deployment write access, and status cleanup failures can prevent preview resources from being deleted.

3 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread .github/workflows/preview-deploy.yml
Comment thread .github/workflows/preview-deploy.yml
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No stories are affected by this PR's changes; nothing to compare. Logs

Updated (PT): Oct 14, 2026, 05:02:39 AM

Copilot AI balanced review requested due to automatic review settings October 14, 2026 11:52
@ruudandriessen
ruudandriessen force-pushed the t3/use-github-deployments branch from 521d9c1 to c31bfeb Compare October 14, 2026 11:52
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing October 14, 2026 11:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design October 14, 2026 11:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs October 14, 2026 11:52 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex October 14, 2026 11:52 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

App-specific validation, silent cleanup failures, and repeated historical status updates need correction.

2 open findings
3 resolved since last review

🧠 Review effort: Balanced

Comment thread .github/scripts/preview-deploy/deployments.mjs
Comment thread .github/workflows/preview-deploy.yml
@ruudandriessen
ruudandriessen merged commit fec5f1c into main Oct 16, 2026
43 checks passed
@ruudandriessen
ruudandriessen deleted the t3/use-github-deployments branch October 16, 2026 09:27

This branch was successfully deployed

No deployments
preview/apollo-vertex — c31bfeb3 Deployed Oct 14, 2026 by github-actions[bot]
preview/apollo-docs — c31bfeb3 Deployed Oct 14, 2026 by github-actions[bot]
preview/apollo-design — c31bfeb3 Deployed Oct 14, 2026 by github-actions[bot]
preview/apollo-landing — c31bfeb3 Deployed Oct 14, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants