Skip to content

fix(apollo-vertex): drop IBM Plex from the theme's serif and mono stacks - #1337

Merged
ruudandriessen merged 1 commit into
mainfrom
claude/vibrant-franklin-l8tkf5
Oct 13, 2026
Merged

ruudandriessen merged 1 commit into
mainfrom
claude/vibrant-franklin-l8tkf5

Conversation

@kittyyueli

Copy link
Copy Markdown
Member

Summary

  • apollo-vertex-theme names IBM Plex Serif / IBM Plex Mono in --font-serif / --font-mono (light + dark).
  • Nothing loads IBM Plex: the theme ships only font-inter, and the docs app loads Inter alone. Browsers fall through to ui-serif / ui-monospace anyway.
  • Consumers that drop the dead names get them restored on every shadcn add --overwrite refresh.

Changes

File Change
packages/apollo-vertex/registry.json font-serif: ui-serif, serif, font-mono: ui-monospace, monospace (light + dark)
apps/apollo-vertex/lib/foundation-tokens.ts Mono token label/stack to match

No visual change: the rendered font is the same system font as before.

🤖 Generated with Claude Code

https://claude.ai/code/session_01618MA7vEk5eKQ3BSuKLCNC


Generated by Claude Code

Nothing loads IBM Plex: the theme ships only Inter, and the docs app
loads Inter alone. Naming it renders the system font anyway and makes
consumers that remove it see the name restored on every refresh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01618MA7vEk5eKQ3BSuKLCNC
Copilot AI balanced review requested due to automatic review settings October 12, 2026 21:27
@kittyyueli
kittyyueli requested a review from a team as a code owner October 12, 2026 21:27
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Apollo Coded App preview deployments are ready.

Project Status Preview Updated (PT)
apollo-design Ready Preview · Logs Oct 12, 2026, 02:36:35 PM
apollo-docs Ready Preview · Logs Oct 12, 2026, 02:36:35 PM
apollo-landing Ready Preview · Logs Oct 12, 2026, 02:36:35 PM
apollo-vertex Ready Preview · Logs Oct 12, 2026, 02:36:35 PM

@github-actions github-actions Bot added the size:S 10-29 changed lines. label Oct 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The theme and documentation changes are consistent, complete, and preserve existing fallback behavior.

0 open findings

What changed in this PR

Removes unused IBM Plex fallbacks from Apollo Vertex font stacks while preserving rendered system fonts.

Changes:

  • Updates serif and mono theme stacks for light and dark modes.
  • Aligns the typography documentation’s mono token metadata.
File Description
packages/​apollo-vertex/​registry.json Removes IBM Plex from theme font stacks.
apps/​apollo-vertex/​lib/​foundation-tokens.ts Updates the documented mono stack and label.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1951 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1721
ISC 88
Apache-2.0 56
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Copy link
Copy Markdown
Member Author

enable-auto-merge failed with GraphQL: Resource not accessible by integration (enablePullRequestAutoMerge): the releaser app's token was refused when enabling auto-merge. Not caused by this diff (2 JSON/TS value edits). The same job fails on other vertex PRs (e.g. #1333 and earlier runs on #1335). No fix exists in this repo yet; re-running once.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No stories are affected by this PR's changes; nothing to compare. Logs

Updated (PT): Oct 12, 2026, 02:37:50 PM

@ruudandriessen
ruudandriessen merged commit 6f1d0fd into main Oct 13, 2026
49 of 51 checks passed
@ruudandriessen
ruudandriessen deleted the claude/vibrant-franklin-l8tkf5 branch October 13, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:S 10-29 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants